Closed jsalvatier closed 8 years ago
Yes, it looks like the React JSX transforms aren't being done.
webppl-viz isn't, in the strictest sense, a webppl package. Because it installs the viz
object into the global namespace, you don't have to bundle it with webppl for it to work.
You can just include the webppl-viz.js and webppl-viz.css files along side your webppl bundle in the browser and things should just work.
If that workflow doesn't work for you guys, then the appropriate fix is probably to modify the webppl Gruntfile so that we can specify transforms on a per-require
basis.
We're using that workflow now for agentmodels (since e17b148). John, can you take a stab at using it for gridworld as well?
@jsalvatier There's been enough demand for rendering from the command line that it made sense for me to make webppl-viz usable as a webppl package (i.e., make it work with --require
)
As of b8332fd5af990b325653febeb148a4427f27f1df, there's no more JSX, so I believe that bundling should work again. Can you try this and let me know whether it works for you? If so we can close the issue.
Yup, this worked.
Bundling webppl and webppl-viz together no longer seems to work (which agentmodels.org uses to run viz in the browser). Looks like you recently moved to React which does some code transformation and that's not happening during bundling?