search

probmods / webppl-viz

Visualization for WebPPL
http://probmods.github.io/webppl-viz/
Other
14 stars 9 forks source link

Requiring package causes stuff to be logged to the console #44

Closed chrisranderson closed 8 years ago

chrisranderson commented 8 years ago

Just by requiring the package, I get this logged to the console when I run my script:

{
 "skill": "x",
 "country": "facetCol",
 "group": "color"
}
{
 "skill": "x",
 "country": "facetCol",
 "group": "facetRow"
}
{
 "skill": "x",
 "group": "facetCol",
 "country": "color"
}

...etc

Also, a dumb question: calling viz.* gives me viz is not defined. Is a different variable exposed?

longouyang commented 8 years ago

I fixed the viz not defined issue in 667b672 (using webpplViz would have worked, but it's nicer to be able to just use viz on both browser and cli).

And I fixed the logging stuff in 91c3537 (I've been working on some newer fancy stuff the past few days and the repo has been in a little bit of a hairy state).

More generally -- bear with us as the PPAML summer school approaches (we'll be moving pretty fast and breaking stuff pretty fast)

chrisranderson commented 8 years ago

No worries! Good luck with the next few days, I bet it's kinda crazy.

Want a hand with something? I can work on docs for all the functions in the header file, or maybe there is something more pressing that I could be productive with.

If it helps me prepare for the summer school I don't feel too bad working on it at work.

On Tue, Jul 12, 2016, 12:47 AM Long Ouyang notifications@github.com wrote:

Closed #44 https://github.com/probmods/webppl-viz/issues/44.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/probmods/webppl-viz/issues/44#event-719706204, or mute the thread https://github.com/notifications/unsubscribe/AFNVloQAXKthI-MGswUmOacqeDtriurUks5qUzhogaJpZM4JJ5Ht .

longouyang commented 8 years ago

We'd appreciate any help you could spare!

Header docs might be the easiest place to help out right now -- I'm actually not sure what the status of that is, so maybe ping Paul (@null-a).

null-a commented 8 years ago

We now have basic docs for lots of the header, here for example. The plan is to gradually improve these over time. Any PRs that do so will be welcome!

There are a few issues from the current milestone up for grabs. Of those, #326 is probably the most approachable. There are also other documentation issues you might look at if that's something of interest to you. Feel free to comment on any other issues you're considering working on but could use pointers for before getting started. I'm happy to try and pick out a few candidate issues if you'd like.

chrisranderson commented 8 years ago

Ones I was thinking about:

I have time until the 20th to help, so feel free to put me to work. :)

null-a commented 8 years ago

so feel free to put me to work. :)

They all sound pretty reasonable to me, go for it! My only advice would be 1) keep any PRs reasonably small so that they are easy to review and 2) maybe comment on issues you're working on so we avoid duplicating effort.

Short PRs will be particularly useful while folk are busy with prep for the summer school. This might make point 3 on your list tricky, depending what you have in mind.

Let's move any further discussion of this elsewhere so we're not cluttering up this (unrelated) issue. The mailing list or specific issues will probably work.