search

probmods / webppl-viz

Visualization for WebPPL
http://probmods.github.io/webppl-viz/
Other
14 stars 9 forks source link

Some heatMap function signatures are broken #45

Closed longouyang closed 7 years ago

longouyang commented 8 years ago

These work:

// samples of objects
viz.heatMap(repeat(2e2, function() { return {a: gaussian(0,1), b: beta(0.5,0.5)} }) )
// dist: supply n as option
viz.heatMap(MH(function() { return {a: gaussian(0,1), b: beta(0.5,0.5)} }, 2e2),
            {n: 2e2})

These don't:

// non-object-y format stopped working
viz.heatMap(repeat(2e2, function() { [gaussian(0,1), beta(0.5,0.5)] }) )

// n is not actually optional for dist signature
viz.heatMap(MH(function() { return {a: gaussian(0,1), b: beta(0.5,0.5)} }, 2e2))
longouyang commented 7 years ago

Fixed by 5e85c4a, a24cbf4