search

probonopd / ESP8266HueEmulator

Emulate a Philips Hue bridge running on an ESP8266 using the Arduino IDE.
MIT License
411 stars 93 forks source link

Fix compliation issues #121

Closed Solmath closed 4 years ago

Solmath commented 5 years ago

Due to changes in various dependencies (ESP8266core, NeoPixelBus) the project wouldn't compile using platformIO. Also some minor issues that resulted in compiler warnings were fixed.

Solmath commented 5 years ago

Fixes #120

probonopd commented 5 years ago 
In file included from /home/travis/build/probonopd/ESP8266HueEmulator/ESP8266HueEmulator/ESP8266HueEmulator.ino:11:0:
/home/travis/arduino_ide/libraries/NtpClient/src/NtpClientLib.h:105:25: fatal error: ESPAsyncUDP.h: No such file or directory
 #include <ESPAsyncUDP.h>
probonopd commented 5 years ago

Also, we should fix the very commit of each library using git clone -o <hash> in .travis.yml so that things don't break again when libraries change over time. Like we do in https://github.com/probonopd/WirelessPrinting/blob/master/.travis.yml.

Solmath commented 5 years ago 
In file included from /home/travis/build/probonopd/ESP8266HueEmulator/ESP8266HueEmulator/ESP8266HueEmulator.ino:11:0:
/home/travis/arduino_ide/libraries/NtpClient/src/NtpClientLib.h:105:25: fatal error: ESPAsyncUDP.h: No such file or directory
 #include <ESPAsyncUDP.h>

Sorry, I forgot to mention that I included ESPAsyncUDP library from https://github.com/me-no-dev/ESPAsyncUDP manually, because it doesn't seem to be included in https://github.com/esp8266/Arduino.

So in my lib folder I now have aJson, ESPAsyncUDP, NtpClient and Time.

Solmath commented 5 years ago

There's still a problem with the flush() function of aJson that I only fixed locally. Working on it now.

Edit: https://gitlab.com/xarduino/lightsw/blob/master/patch/ajson-void-flush.patch

Solmath commented 5 years ago

My last commit should have done the trick for ESP8266HueEmulator.ino, but I can't get the Json-Example to compile.

aJson seems not to be supported anymore and the example is not crucial to this project in my opinion.

probonopd commented 5 years ago

Please review your PR, I think you have added too many files (including aJSON).

Solmath commented 5 years ago

Sorry, major f***up. This commit was not planned to go into the PR at all and should only be in my fork. I guess I wasn't thinking quite straight anymore last night.

I'll move the last commits to a separate branch as soon as I come home tonight and hope this will fix it.

Solmath commented 5 years ago

Reset origin/master to the correct commit and created branch platformio for my additional changes.

I promise to use separate branches for PRs in the future, I'm just not really used to the workflow, yet.

probonopd commented 5 years ago

Looking better, now we need to make it build...

Solmath commented 5 years ago

Skipping the Json_Example.ino now, but the travis build just stops after the aJson example sketches. I guess that's not the expected behaviour.

Does it make sense to build all *.ino files (including examples from libraries), or would it be better to call the arduino build for the main sketch as in the WirelessPrinting repo?

probonopd commented 5 years ago

I'd say the main sketch is sufficient, what do you think?

Solmath commented 4 years ago

Finally found the time to fix the remaining issues after only eight months (sory about that).

probonopd commented 4 years ago

Thank you very much @Solmath