Build with gtk3 toolkit

[favadi]

Hi, any reason you build this with gtk2 instead of gtk3? In my case, gtk2 tool kit doesn't work well with HiDPI screen, so gtk3 is better.

[probonopd]

I think gtk2 is more common (every distro supports it out-of-the box).

But you're welcome to send a pull request that builds it with gtk3.

[favadi]

I modify the build script to compile with gtk3, it seems to work fine. You can download to the binary here.

[favadi]

The PR #3.

[favadi]

Actually after use it for few minutes, there are something weird about font size. Please don't merge my MR, I'm investigating.

[favadi]

The weird font rendering problem is fixed when I disable xwidgets and cairo support, this binary works fine.

[probonopd]

@favadi forgive me for what may be a stupid question, are there actual advantages for the user, besides having a higher version number?

Your binary works for me.

[favadi]

Gtk2 doesn't support HiDPI, in my case with scaling factor = 2, the toolbar, scrollbar, menubar all look tiny. Compile with gtk3 fix it.

On February 22, 2017 2:24:33 AM probonopd notifications@github.com wrote:

@favadi forgive me for what may be a stupid question, are there actual advantages for the user, besides having a higher version number?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/probonopd/Emacs.AppImage/issues/2#issuecomment-281451995

[probonopd]

Gtk2 doesn't support HiDPI, in my case with scaling factor = 2, the toolbar, scrollbar, menubar all look tiny. Compile with gtk3 fix it.

That's a good use case for sure.

[probonopd]

Thanks @favadi, merged code and added to Releases page.