search

probonopd / Filer

A clean rewrite of the Filer file manager for helloSystem, inspired by John Siracusa's descriptions of "Spatial Orientation"
BSD 2-Clause "Simplified" License
12 stars 1 forks source link

libsqsh tips #1

Closed Gottox closed 1 year ago

Gottox commented 1 year ago

https://github.com/probonopd/Filer/blob/d254dadbc8495783b6a6b080c804e4e3b4fc7a13/src/SqshReader.cpp#L69-L74 You can actually use sqsh_directory_iterator_name_dup(iterator) to get a zero terminated string. It actually does exactly the same as you're doing manually here.

probonopd commented 1 year ago

Thanks for your careful review. I have adopted your suggested improvement.