search

probonopd / Filer

A clean rewrite of the Filer file manager for helloSystem, inspired by John Siracusa's descriptions of "Spatial Orientation"
BSD 2-Clause "Simplified" License
13 stars 1 forks source link

update libsqsh to v1.0.0 #2

Closed Gottox closed 1 year ago

Gottox commented 1 year ago

This commit updates libsqsh to v1.0.0. It replaces usages of the low level API with the new easy API.

probonopd commented 1 year ago

Thank you very much @Gottox, this is a very welcome contribution.

The build succeeds on FreeBSD but strangely not on Ubuntu. Would you happen to know why this is?

Again, thanks for making this incredibly useful library, and for supporting me in using it properly.

Gottox commented 1 year ago

Should be fixed:

(still failing due to an attempted release)

Thanks for using the library! ^^

probonopd commented 1 year ago

Hi @Gottox, thanks for your help.

Unfortunately I have to roll back this change for now. It compiled fine, but it ran into the following issue during runtime,

Extracting AppImage icon for file "/home/user/Desktop/appimagetool-730-x86_64.AppImage"
Assertion failed: (acc == 0), function cx_rc_map_cleanup, file ../subprojects/cextras-887bee6835d5fa8213a8f9ffbdf3a26f119983a3/lib/collection/rc_map.c, line 222.

This leads to the file manager to crash. With the old code, it works.

Here is the file (please unzip it) for testing: appimagetool-730-x86_64.AppImage.zip

Is there a way to change the code in Filer and/or in libsqsh so that even if a file cannot be read or extracted, the whole application will not crash?

Gottox commented 1 year ago

Ah, that's the error that happens when resources aren't cleaned up properly. Could you post a stacktrace?

probonopd commented 1 year ago

Unfortunately I have already rolled everything back, sorry.

Gottox commented 1 year ago

No big deal^^

Gottox commented 1 year ago

Ah, I think I know what's happening. Could it be, that the archive was corrupt or you tried to access files that did not exist? - We totally missed handling error cases in the PR.

probonopd commented 1 year ago

I was trying to access the /.DirIcon file from the file I linked above.

Gottox commented 1 year ago

can you provide the offset of this file? - or a way to retrieve it.

probonopd commented 1 year ago

Sure:

~/Desktop/appimagetool-730-x86_64.AppImage --appimage-offset
594264
Gottox commented 1 year ago

Superseeded by #4