Closed Gottox closed 1 year ago
Thank you very much @Gottox, this is a very welcome contribution.
The build succeeds on FreeBSD but strangely not on Ubuntu. Would you happen to know why this is?
Again, thanks for making this incredibly useful library, and for supporting me in using it properly.
Should be fixed:
(still failing due to an attempted release)
Thanks for using the library! ^^
Hi @Gottox, thanks for your help.
Unfortunately I have to roll back this change for now. It compiled fine, but it ran into the following issue during runtime,
Extracting AppImage icon for file "/home/user/Desktop/appimagetool-730-x86_64.AppImage"
Assertion failed: (acc == 0), function cx_rc_map_cleanup, file ../subprojects/cextras-887bee6835d5fa8213a8f9ffbdf3a26f119983a3/lib/collection/rc_map.c, line 222.
This leads to the file manager to crash. With the old code, it works.
Here is the file (please unzip it) for testing: appimagetool-730-x86_64.AppImage.zip
Is there a way to change the code in Filer and/or in libsqsh so that even if a file cannot be read or extracted, the whole application will not crash?
Ah, that's the error that happens when resources aren't cleaned up properly. Could you post a stacktrace?
Unfortunately I have already rolled everything back, sorry.
No big deal^^
Ah, I think I know what's happening. Could it be, that the archive was corrupt or you tried to access files that did not exist? - We totally missed handling error cases in the PR.
I was trying to access the /.DirIcon
file from the file I linked above.
can you provide the offset of this file? - or a way to retrieve it.
Sure:
~/Desktop/appimagetool-730-x86_64.AppImage --appimage-offset
594264
Superseeded by #4
This commit updates libsqsh to v1.0.0. It replaces usages of the low level API with the new
easy
API.