probonopd / MiniDexed

Dexed FM synthesizer similar to 8x DX7 (TX816/TX802) running on a bare metal Raspberry Pi (without a Linux kernel or operating system)
https://github.com/probonopd/MiniDexed/wiki
1.07k stars 78 forks source link

Improve performance.ini format #558

Closed probonopd closed 10 months ago

probonopd commented 10 months ago

We should improve https://github.com/probonopd/MiniDexed/blob/main/src/performanceconfig.h/.cpp so that we can use something like

; Tone Generator 1
[TG1]
Key=Value

; Tone Generator 2
[TG2]
Key=Value

Maybe we need to investigate something like https://github.com/pulzed/mINI to read and write a more complete .ini format?

probonopd commented 10 months ago

Looks like the infrastructure for this might land in Circle sooner or later.

diyelectromusic commented 10 months ago

I'm not really sure what the complexity offers over the existing format. Once preset performances are defined, most people would only be saving them from the UI, so won't really benefit from a more user-readable format anyway?

If we did anything (and I'm not convinced we should tbh) then moving to a binary sysex format (as described here: https://github.com/probonopd/MiniDexed/issues/533) probably makes more sense, especially if tools will be required to read/write the new files...?

And if we're writing tools, then a converter from a format like the above to the existing format probably is a lot easier than adding support directly in MiniDexed (even if added to circle)?

Kevin

probonopd commented 10 months ago

I'm not really sure what the complexity offers over the existing format

Would have made it easier (a bit) to read and write by hand.

But possibly not worth the effort, especially now that tools and performances already exist.