search

probonopd / WirelessPrinting

Print wirelessly from Cura, PrusaSlicer or Slic3r to your 3D printer connected to an ESP8266 or ESP32 module
352 stars 65 forks source link

[QUESTION] Web Firmware update #105

Closed GMagician closed 5 years ago

GMagician commented 5 years ago

I'm wondering... no filename validation... no password protection...isn't it a little bit dangerous?

GMagician commented 5 years ago

Another question..it's ok version on web page has no 2.0.x but only build number?

probonopd commented 5 years ago

I'm wondering... no filename validation... no password protection...isn't it a little bit dangerous?

For my own private use it's the most convenient, exactly what I personally need, no hassle. But I can see that not everyone might want this, so we could possibly use HTTP Basic Auth or something like that if a password is set for the OTA.

Another question..it's ok version on web page has no 2.0.x but only build number?

Yes. I am not a huge fan of version numbers, I like git sha commit hashes. The commit hash should be directly linked to the commit, so that you can click on it to see exactly which code you are running.