probonopd / WirelessPrinting

Print wirelessly from Cura, PrusaSlicer or Slic3r to your 3D printer connected to an ESP8266 or ESP32 module
352 stars 65 forks source link

uniform coding style #49

Closed GMagician closed 5 years ago

GMagician commented 5 years ago

Added indentation to includes moved all include at beginning uniformed some coding style

probonopd commented 5 years ago

Thanks. Does it compile for you locally?

GMagician commented 5 years ago

I'm managing to download and install required library. As told before I'm not so skilled with Arduino environment so give me some minutes. These first step is not so invasive so it shouldn't give any error...

GMagician commented 5 years ago

I removed something by error, now locally it compiles

probonopd commented 5 years ago

Now it also compiles here 👍

Did you test the resulting sketch, so that you know if really prints and does not crash? I am asking because I often compiled this sketch and then found out that it crashes when running it, even when I was doing innocent-looking changes.

GMagician commented 5 years ago

At the moment I programmed my d1 mini with original master complied code and I'm trying to configure wifi connection. I want to connect it to my mega2560 but it's 5V and not 3.3V so I don't know how to proceed. I would like to buy a new 32 bits card (ruramps4d/due or new all-in-one from ruramps4d producer but it will be ready in january/february) so I think I have to wait a long before really use it

probonopd commented 5 years ago

Let's merge this only after it has been tested in practice for actual 3D printing.

GMagician commented 5 years ago

I'm doing a massive work on this program, I'll post something when tested. Such work will include also this...