search

probonopd / go-appimage

Go implementation of AppImage tools
MIT License
744 stars 73 forks source link

Support monitoring directories outside of $HOME for preseeding #102

Open eMPee584 opened 3 years ago

eMPee584 commented 3 years ago

For our https://schulstick.org/ live USB distro, we want to ship with appimaged enabled [0] to provide seamless integration, which seems to be working well overall (thanks!). Also, we want to have the possibility of shipping certain variants (like the "Makerstick") with specific AppImages where this is the most convenient method of providing more recent program versions than available as native debian packages (example: freecad 0.19 builds with assembly 3 integrated [1]). The adequate location for pre-seeding would be either /opt or a folder in /usr/local/ IMHO.. However, there seems no way to add existing appimages in there.. What would be the sanest / your preferred way to allow that? Simply adding these folders to the candidateDirectories array?

[0] https://github.com/fsfw-dresden/usb-live-linux/tree/master/features/hook_install_appimaged [1] https://github.com/realthunder/FreeCAD_assembly3

probonopd commented 3 years ago

Wow, this is a very worthy project, I'd like to give you full support. :+1: (And I'd like to try "Makerstick" myself.)

Can you add the AppImages to ~/Applications? They should be picked up from there automatically.

probonopd commented 3 years ago

Now that you are saying it, I think I have spotted a bug in

https://github.com/probonopd/go-appimage/blob/d1d2094ae63ec632bb204c83be62b38af48fdbfd/src/appimaged/appimaged.go#L79-L87

The home + in the last two lines is wrong...

In which location would you ideally like to store your AppImages?

eMPee584 commented 3 years ago

Well these last two would be very fine I think.. when I first glanced at the code I totally missed the home + in front of these paths, so I was a bit confused why it wouldn't pick up AIs in these dirs... then I was confused because why would anyone put these into his HOME dir :rofl: .. if it was unintended, that clears things up : ) Note I tried symlinking AIs from /opt, but it would only pick those up after renaming and, confusingly, the resulting desktop files did not show up in the xfce menu. I'll have another look at it as the VM is still running..

probonopd commented 3 years ago

Next build should have it fixed.