search

probonopd / go-appimage

Go implementation of AppImage tools
MIT License
813 stars 71 forks source link

Adjust download script to work with githubs new API #224

Closed borgmanJeremy closed 2 years ago

borgmanJeremy commented 2 years ago

The current wget command in the README does not work anymore. Github changed their website so the actual release info is no longer embedded into the html and is dynamically loaded.

To properly fetch the latest releasing info they recommend using their API as described here: https://docs.github.com/en/rest/releases/releases#list-releases

This changes the README to use the new API and filter with jq (since its parsing JSON).

probonopd commented 2 years ago

Thanks @borgmanJeremy

While

wget $(curl https://api.github.com/repos/probonopd/go-appimage/releases | jq -r '.[] | select(.tag_name == "continuous") | .assets[] | select((.name | endswith("x86_64.AppImage")) and (.name | contains("appimagetool"))) | .browser_download_url') -O appimagetool

will work it needs jq which may not be installed everywhere. So I am using

wget -c https://github.com/$(wget -q https://github.com/probonopd/go-appimage/releases/expanded_assets/continuous -O - | grep "appimagetool-.*-x86_64.AppImage" | head -n 1 | cut -d '"' -f 2)

now. Does that work for you?