probonopd / go-appimage

Go implementation of AppImage tools
MIT License
676 stars 69 forks source link

Reorganization #249

Closed CalebQ42 closed 9 months ago

CalebQ42 commented 1 year ago

This is mostly some re-organization and cleanup loosely similar to #234

And a couple features for appimaged:

probonopd commented 1 year ago

Thanks a lot @CalebQ42. As a general rule, I'd like to avoid configurability in appimaged when possible; ideally it should "just work" for everyone in the same way.

But since so many people have reported issues with the current state of MQTT (and it is experiemental, as is the rest of the tools) I think we should disable it for now by default and only use it if explicitl requested by the user.

CalebQ42 commented 1 year ago

I think having a couple options that don't change the actual functionality could be useful. In particular, in #178 it's mentioned that disabling desktop notifications would be very nice to have. In that issue it was mentioned to check for the existence of a file (~/.config/appimaged/no_desktop_notifications), but a flag was already in the code so I went ahead and just hooked that up.

For the MQTT update service, I agree that it would probably be best to default it to disabled until it get some work, but it's probably best to keep it available to allow for easier testing. In these cases, would you prefer to pass-through the flags used when installing the service or simply leave it and if someone really wants to use the flags then they'll have to manually edit the service file themselves?