search

probonopd / go-appimage

Go implementation of AppImage tools
MIT License
756 stars 74 forks source link

Also look up for icons in usr/share/icons/hicolor/scalable/apps/ #254

Closed lephilousophe closed 1 year ago

lephilousophe commented 1 year ago

SVGs are traditionally stored in /usr/share/icons/hicolor/scalable/apps/ so this makes sense to look up for icons in this folder too.

probonopd commented 1 year ago

Thanks @lephilousophe.

Thing is, it is way easier for thumbnailers to parse/show png rather than svg. So I am not entirely sure whether we should allow svg icons. But I guess since the existing code says supportedIconExtensions := []string{".png", ".xpm", ".svg"} I should probably merge this for now.

probonopd commented 1 year ago

Maybe we should at least print a warning if if only a SVG but no PNG is found, letting the user know that a PNG should be used.

lephilousophe commented 1 year ago

I must admit that in ScummVM we don't use a PNG on linux only a SVG icon. By looking at Icon Theme Specification, I see that SVG is optional and XPM is deprecated so, yes, warnings may be useful. I will add them.

lephilousophe commented 1 year ago

And done.

probonopd commented 1 year ago

Thanks @lephilousophe