search

probonopd / go-appimage

Go implementation of AppImage tools
MIT License
818 stars 71 forks source link

Appimagetool is deploys `libX11-xcb.so.1` which is on the exclude list #305

Open Samueru-sama opened 2 months ago

Samueru-sama commented 2 months ago

I was doing some tests with thunar and I discovered this:

image

libX11-xcb.so.1 gets deployed even though it is on the exclude list.

The reason is likely because it is not on the internal list that go-appimage uses that hasn't been updated in 5 years?

probonopd commented 2 months ago

I think genexclude.go is supposed to update that list; possibly we are not running it (properly) when building go-appimage? We should make it so that it runs whenever the GitHub Actions job runs, and possible delete the static file. We should not have such lists in multiple places. PR would be appreciated.

probonopd commented 3 weeks ago

This being said, I use -s deploy most of the time anyways, in which case the excludelist is not used at all. (For lean AppImages, best build the ingredients on Alpine Linux with musl libc.)