probot / adapter-aws-lambda-serverless

An extension for running Probot on Lambda
ISC License
94 stars 36 forks source link

feat: Support Probot v12 #83

Closed jaylenw closed 3 years ago

jaylenw commented 3 years ago

What does this PR do?

The pull request has changes that includes updating the Probot dependency from v11 to v12, updating dependencies that includes Jest, Nock, and Prettier, and modifying the tests to reflect the changes that were introduced by upgrading Probot.

Background info

Probot v12 has been released. The adapter has to be updated to be compatible with this latest release of the Probot Framework.

Please view #82 for additional background info.

Useful links that were referenced to make the changes included in this PR:

How can this be tested (manually and/or automated test)?

Unit Tests

1.) Checkout this branch and run npm install.

2.) Run npm run lint and see that linting passes.

3.) Run npm test and you should see all the tests succeed.

> jest --coverage

 PASS  test/index.test.js
  @probot/adapter-aws-lambda-serverless
    ✓ happy path (87 ms)
    ✓ lowercase request headers (62 ms)
    ✓ GitHub request headers (46 ms)
    ✓ camelcase request headers (#62) (34 ms)

---------------------------------------------|---------|----------|---------|---------|-------------------
File                                         | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
---------------------------------------------|---------|----------|---------|---------|-------------------
All files                                    |   94.11 |       50 |     100 |   94.11 |                   
 adapter-aws-lambda-serverless               |    92.3 |       50 |     100 |    92.3 |                   
  index.js                                   |     100 |      100 |     100 |     100 |                   
  lambda-function.js                         |    87.5 |       50 |     100 |    87.5 | 29                
 adapter-aws-lambda-serverless/test/fixtures |     100 |      100 |     100 |     100 |                   
  app.js                                     |     100 |      100 |     100 |     100 |                   
---------------------------------------------|---------|----------|---------|---------|-------------------
Test Suites: 1 passed, 1 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        3.017 s
Ran all test suites.

Manual tests

We copied the repository with these changes included into our node_modules/@probot/adapter-aws-lambda-serverless folder of our Probot application to make sure the issue seen in #82 was resolved.

Which issue(s) is/are related to this PR?

This PR is related to issue #82 close #82

BREAKING CHANGE: Probot dependency has been upgraded from Probot v11 to v12.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jaylenw commented 3 years ago

thanks a lot! There don't seem to be any breaking changes, but I'll release it as a breaking version anyway, out of caution

@gr2m You're welcome and thank you!! 😀