search

probot / adapter-aws-lambda-serverless

An extension for running Probot on Lambda
ISC License
94 stars 36 forks source link

Don't Call `JSON.parse` on `event.body` #89

Closed ajschmidt8 closed 2 years ago

ajschmidt8 commented 2 years ago

Fixes #78.

This PR removes the JSON.parse call from event.body. This was causing issues when trying to invoke Lambda functions asynchronously with async set to true in a serverless.yaml config file. I'm not exactly sure why this doesn't cause issues when async is not set to true, but I tested these changes with http events (both async: true and async: false) and httpApi events and it seemed to work fine on both. Also, I believe the verifyAndReceive function internally handles both objects and strings anyway.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: