search

probot / adapter-github-actions

:electric_plug: An adapter that takes a Probot app and makes it compatible with GitHub Actions
ISC License
86 stars 19 forks source link

Adapter has too many deps #20

Closed jetersen closed 3 years ago

jetersen commented 3 years ago

Seems the adapter is having too many deps, nock should definitely be a dev dependency. https://github.com/probot/adapter-github-actions/blob/34665d741b53510af74aa065efb3fb459c2263c1/package.json#L31-L35

gr2m commented 3 years ago

Oopsies! It should indeed, yes. The others are correct though, they are all used for logging in https://github.com/probot/adapter-github-actions/blob/34665d741b53510af74aa065efb3fb459c2263c1/pino-transport-github-actions.js

Can you send a pull request to move nock to devDependencies?

GitHub
probot/adapter-github-actions
:electric_plug: An adapter that takes a Probot app and makes it compatible with GitHub Actions - probot/adapter-github-actions
jetersen commented 3 years ago

created #21

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: