search

probot / github-app

node module to handle authentication for the GitHub Apps API
51 stars 19 forks source link

replaced deprecated github pkg with @octokit/rest #13

Closed cirpo closed 6 years ago

cirpo commented 6 years ago

jsonwebtoken updated to version ^8.2.1 standard updated to version ^11.0.1

ci-reporter[bot] commented 6 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 5226763b169963d8c3c072b37e77b9cb510a6c59. Here's the output:

npm test
> github-app@3.2.0 test /home/travis/build/probot/github-app
> standard

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /home/travis/build/probot/github-app/index.js:33:49: Multiple spaces found before '// Issued at t...'.
  /home/travis/build/probot/github-app/index.js:34:49: Multiple spaces found before '// JWT expirat...'.
  /home/travis/build/probot/github-app/index.js:35:49: Multiple spaces found before '// Integration...'.

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
Glavin001 commented 6 years ago

Any reason this is not merged yet? I want to use new features such as https://github.com/octokit/rest.js/pull/852 .

@cirpo do you have a workaround until this is merged? Are you using your fork instead?

Glavin001 commented 6 years ago

Looks like Probot has removed github-app dependency: https://github.com/probot/probot/pull/333/files

GitHub
Absorb github-app repo by JasonEtco · Pull Request #333 · probot/probot
As part of the development of #331, it has become clear that the github-app repo can be absorbed into probot/probot. This is kinda necessary to simplify GitHub Enterprise support, but also just mak...
bkeepers commented 6 years ago

Thanks @cirpo. 4.0 is released with this change.