probot / ideas

Share ideas for new GitHub Apps built with Probot
96 stars 48 forks source link

Don't dismiss stale reviews if the code diff doesn't change on rebase #124

Open cseas opened 2 years ago

cseas commented 2 years ago

When we have the "Dismiss stale pull request approvals when new commits are pushed" rule enabled for a branch, every new commit pushed to a Pull Request after an Approval will dismiss that approving review automatically.

This becomes a problem for teams that need to rebase their branches often because every rebase dismisses the pull request approval and we need to find the reviewer to approve the Pull Request again even when there are no new changes.

As pointed out in this GitHub Community thread, it might be possible to achieve this behaviour using Probot.