search

probot / ideas

Share ideas for new GitHub Apps built with Probot
96 stars 48 forks source link

repolinter-bot #73

Open jwsloan opened 6 years ago

jwsloan commented 6 years ago

I started working on a bot wrapping https://github.com/todogroup/repolinter.

I'm wondering if probot is really right for that, though. It has to clone the repo, and walks through all files, and all of the git history.

Thoughts?

wei commented 6 years ago

Are you thinking about running this each time a commit is pushed? Great idea, you can use the check api. repolinter handles all the messy stuff, so you could just use child_process.exec to run the git clone and npx repolinter (never tried, should work thou)

Berkmann18 commented 6 years ago

Sounds like a great idea.

tunnckoCore commented 6 years ago

It's really not needed to git clone or do any server stuff. The reason i didn't do that yet (while thinking for such for over a year) is that i didn't think checking through the API is a good idea.

But now. It sounds like a good idea, because it won't lint everything but only the files in which have changes.

One the other hand. I'm still against, because i more fan of the "before you commit" do things. So you are mostly impossible even to commit if you do the wrong thing - just not make sense to stress the API and users.

In anyway, it's easy thing, i think.