search

probot / octokit-plugin-config

🛠️ Get/set persisted configuration using YAML/JSON files in repositories
ISC License
35 stars 16 forks source link

feat: deepmerge by default #263

Open Uzlopak opened 1 month ago

Uzlopak commented 1 month ago

BREAKING CHANGE: Use @fastify/deepmerge to deepmerge configurations BREAKING CHANGE: defaults option does not accept a merge function anymore BREAKING CHANGE: adding new merge option, which can be used to override the the default merge strategy

Uzlopak commented 1 month ago

hmm, maybe it is already implemented on probot level. maybe should be implemented on this level. But on probot level it seems to be broken?!

https://github.com/probot/probot/blob/ae034152d98e2ad5968d40d799082e96cc84ef5a/src/context.ts#L234

GitHub
probot/src/context.ts at ae034152d98e2ad5968d40d799082e96cc84ef5a · probot/probot
🤖 A framework for building GitHub Apps to automate and improve your workflow - probot/probot