Reminders

[bkeepers]

@jbjonesjr I was on airplanes this week and decided to work on this. I ended up doing a massive refactor and stripping out the "snooze" part of this and just going with reminders as slash commands. Reminders are the primary feature I've been really wanting.

You can browse each of the commits separately, but it might just be easier to browse the code. I know this is a pretty massive departure from the original direction, so let me know if you have interest in it or not.

I've deployed this to https://github.com/apps/reminders and you can see it in action on https://github.com/probot/test/issues/15#issuecomment-329682268

[bkeepers]

@jbjonesjr I'm going to merge this into master in this fork, but I'm happy to continue chatting about getting these changes upstream and what feature set you imagined for the snooze plugin.

[jbjonesjr]

major changes, but not necessarily a bad thing. I think it would be a shame if snooze and reminder diverged (snooze is really my goal because dat inbox zero life), as they share 99% of the same core. The inputs to both commands are the same, so compatibility would be fairly simple.

The key differences in my mind are:

• snooze will close the issue on command interpretation
• snooze will reopen the issue (if necessary) on reminder wake
• snooze will use a different or more complex command to be triggered to differentiate from remind

Since JS isn't as easily extensible as other languages, I'm open for suggestions on how to let this be managed in a config vs a fork. Spitballing for a second, If this could be kept in a single codebase, it seems like there would have to be the ability to add additional command keywords that correlated with additional actions (like in a pre-command, post-command, pre-wake, post-wake framework).

something like a yaml that was: remind:

• pre-command:
• post-command:
• pre-wake:
• post-wake: snooze:
• pre-command:
• post-command: issue_close
• pre-wake: issue_open
• post-wake:

where a set of actions can be pre-defined that this plugin can take in. This kind of generalizes the entire paradigm into a command/response plugin instead of a straight remind, but this will hopefully lead to more powerful implementations? or maybe this is the only two use cases that make sense ever?

¯_(ツ)_/¯

[bkeepers]

…I think it would be a shame if snooze and reminder diverged…

hear hear!

I don't have any strong feels about implementation, so up for anything that works. I don't really use repos as an inbox, so I defer to you on the best UX for snoozing. Personally, I don't mind clicking the "Comment and close" button along with /remind commands.