search

probot / reminders

set reminders on Issues and Pull Requests
https://github.com/apps/reminders
ISC License
162 stars 24 forks source link

fixes #22 by using template literals #23

Closed itaditya closed 6 years ago

itaditya commented 6 years ago

On line 91 we haven't used template literal. Instead there is an ugly string concatenation. This PR fixes that.

itaditya commented 6 years ago

@JasonEtco please review my PR :smile:

itaditya commented 6 years ago

@gr2m can you check this ? :sweat_smile:

gr2m commented 6 years ago

I wouldn’t call it "ugly string concatenation" you never know if someone is personally attached to an existing implementation, people always have opinions :) I’d suggest to leave out the "ugly" in future, your comment works without it just as good 👍

itaditya commented 6 years ago

OK thanks for the tip

bkeepers commented 6 years ago

Thanks @itaditya!