search

probot / reminders

set reminders on Issues and Pull Requests
https://github.com/apps/reminders
ISC License
162 stars 24 forks source link

chore(package): update jest to v24.5.0 #36

Closed macklinu closed 5 years ago

macklinu commented 6 years ago

When cloning this repo, running npm install and npm test, I am seeing the following error:

❯ npm test

> probot-reminders@1.0.0 test /Users/macklinu/dev/probot/reminders
> jest && standard

 FAIL  test/index.test.js
  ● Test suite failed to run

    SecurityError: localStorage is not available for opaque origins

      at Window.get localStorage [as localStorage] (node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
          at Array.forEach (<anonymous>)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.89s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

I believe this is due to https://github.com/facebook/jest/issues/6766, and updating to the latest version of Jest resolves this issue.

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

macklinu commented 5 years ago

still relevant

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

macklinu commented 5 years ago

still relevant

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?