search

probot / reminders

set reminders on Issues and Pull Requests
https://github.com/apps/reminders
ISC License
162 stars 24 forks source link

doesn't work on PRs #38

Closed derberg closed 5 years ago

derberg commented 6 years ago

Hey, awesome bot but looks like it works on issues only

please take a look:

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

iamareebjamal commented 5 years ago

This should be reopened as it does not work on PRs

flipace commented 5 years ago

I checked this with a fork, and i believe that the permissions for this app must be changed. When configured correctly (= R/W access for PRs) it properly reacts to the sent comments.

So, apparently this published app is only configured to work with issues, but not prs (you can easily see this on the configuration screen of it as well).

Until this is fixed here, i published the same app with proper permissions: https://github.com/apps/reminders-prs

GitHub
Build software better, together
GitHub is where people build software. More than 31 million people use GitHub to discover, fork, and contribute to over 100 million projects.
gillesdemey commented 5 years ago

I also believe this should be reopened, as the original issue is not solved :)

nomeata commented 5 years ago

Thanks @flipace, using your fork now :-)

Hope this can be fixed with the official one at some point.