search

probot / reminders

set reminders on Issues and Pull Requests
https://github.com/apps/reminders
ISC License
162 stars 24 forks source link

Update probot to version > 7.1.1 #50

Closed jakewilkins closed 4 years ago

jakewilkins commented 4 years ago

GitHub is removing the deprecated access token endpoint which version 6 of Probot uses. There's a brownout scheduled this weekend which will impact reminders.

This updates Probot to >7.1.1. which is the earliest version to use the supported endpoint.

I'm new to the Probot ecosystem, so other than this package.json change I'm not sure what steps need to happen for a change like this. Since this is a major version change I imagine there's some other work that needs to be done but out of extreme optimism I'm opening this PR up to see how far it can take us.

🙏 ✨

jbjonesjr commented 4 years ago

@jakewilkins so i fixed the test framework to work, to show .... the tests no longer work.

createRobot can't be found. where is that method/function in the new probot?

jakewilkins commented 4 years ago

Thanks @jbjonesjr!

I'm not sure, I have ~0 familiarity with Probot. 7.1.1 isn't new Probot which is on version 9 now, 7.1.1 is the oldest version which supports the new endpoint. I was hoping to make the diff as small as possible to avoid some of these issues.

jbjonesjr commented 4 years ago

K. I'll review it further this weekend to see if I can find out what's up

jakewilkins commented 4 years ago

👋 Hey @jbjonesjr, were you able to look at this?

Also, heads up that the endpoint used by Reminders will be removed on October 1st 😬 contrary to ismarchoveryet.com October starts next week.

The change is a 1 word change just pre-pending apps/ to the path, if I were more familiar with Probot we might be able to skip the upgrade and just patch the version Reminders is using but I'm not sure if that's possible here.

jbjonesjr commented 4 years ago

Bringing over notes from jakewilkins/reminders#1

This PR now contains: