probot / smee.io

☁️📦 Webhook payload delivery service
https://smee.io
MIT License
348 stars 86 forks source link

Request payload is different from one sent, due to json parsing #78

Closed CRogers closed 3 months ago

CRogers commented 3 years ago

When you hit smee with some json data, for example:

{
   "a": 2
}

smee parses the json and then reformats it when you get it out of the request:

data: {"host":"my-local-smee",...,"body":{"a":2},...}

This is unfortunate as you don't get the exact same data back. In my case, I'm also getting a shared-secret HMAC signature along with the payload, which no longer matches the expected signature. This means that I can't test my payload signature checking code is working with the external service and have to disable it, which is sad.

CRogers commented 3 years ago

I guess #5 is also an effect of this (content-length changes due to the payload being changed).

mosheco commented 2 years ago

When can a new Smee release , fixing this issue, be expected ?

wolfy1339 commented 3 months ago

I don't have control of the infrastructure running the website code. I merged #55 which allows you to have the raw body of a request