probot / stale

A GitHub App built with Probot that closes abandoned Issues and Pull Requests after a period of inactivity.
https://probot.github.io/apps/stale/
ISC License
1.25k stars 212 forks source link

Re open issue with config flag #205

Open tobiasKaminsky opened 5 years ago

tobiasKaminsky commented 5 years ago

Fix #204

It is my first time contributing here and I could not test it. However I hope that this enhancement is straight forward and works as intended.


View rendered README.md

tobiasKaminsky commented 5 years ago

Any feedback on this? I would really love to have this in.

tobiasKaminsky commented 5 years ago

Any feedback here?

tobiasKaminsky commented 5 years ago

Rebased onto latest mastert

hbokh commented 5 years ago

Maybe ping @JasonEtco will help?

JasonEtco commented 5 years ago

👋 I'm not sure I understand the goal here. When an issue is closed and you want to reopen it, couldn't you just reopen it? That will count as activity and prevent Stale from attempting to close it until its stale again, and is a much clearer signal that an issue needs to be talked about again.

tobiasKaminsky commented 5 years ago

@JasonEtco thanks for reply. In our repo only admins can re-open a ticket, but all user can comment on it. And as we have many many issues, I tend to ignore closed tickets, especially since the stale bot.

JasonEtco commented 5 years ago

Appreciate the clarification @tobiasKaminsky! In that case, either this bot would be blocked by the same restrictions, or this would be a mechanism for getting around a restriction explicitly set by repo admins. I'm not sure that that's a good idea, given that people usually enable those things for a reason.

Ignoring closed tickets is kind of the whole point of Stale - if you aren't going to act on it, close it to focus on the issues that you can act on - otherwise reopen them. Frankly, I'd look at lifting that restriction. Sorry if that isn't helpful, but it doesn't sound like a problem that Stale can really fix!

tobiasKaminsky commented 5 years ago

@JasonEtco thanks for keeping up this discussion. So regarding "reopen tickets" I found: https://stackoverflow.com/a/21333938

` If you are not a collaborator of a repo, then (in regards to issues)

you can open issues
you can comment on all existing issues (open or closed)
you can close your own issues
you can re-open your own issues *if you closed them yourself
you cannot close or re-open issues opened by someone else
you cannot re-open your own issues if a repo collaborator closed them

`

This means that if

So in my case, it goes even further:

Stack Overflow
How to re-open an issue in github?
I have reported an issue to a project. Now owner changed it state to closed, but how can I change it to open again ? I read somewhere that I need rights for push and pull operation. Is that true ?
tobiasKaminsky commented 5 years ago

Here is a real life example: https://github.com/nextcloud/android/issues/4667

It got closed by stale bot, which is totally fine. Then someone replied and I ignored it was "just" a response to a closed ticket and from overview I could not see who replied last, if it is was stale-bot or an user. So I stumbled across it by accident and now I have to manually re-open it.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

tobiasKaminsky commented 4 years ago

Is this still relevant?

Yes :-)

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

tobiasKaminsky commented 4 years ago

Still relevant, at least for me ;-) As it is done via a config option, I would love to have this in :-)

mohan43u commented 4 years ago

stale bot closed issues should be re-opened automatically once someone reply on closed issue.

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

williamdes commented 3 years ago

stale bot closed issues should be re-opened automatically once someone reply on closed issue.

👍🏻 🤖