search

probot / stale

A GitHub App built with Probot that closes abandoned Issues and Pull Requests after a period of inactivity.
https://probot.github.io/apps/stale/
ISC License
1.25k stars 212 forks source link

Initial stab at collaboratless comment filter #245

Closed elliotblackburn closed 4 years ago

elliotblackburn commented 5 years ago

First stab at solving https://github.com/probot/stale/issues/147 I guess we can thank Stale for constantly poking me about this issue I raised years ago.

I've not actually run this yet to check it works or written any tests, I wanted to check two things first.

  1. Is this actually a feature that we should add to probot? The issue suggests it's a feature some people desire, I've no idea how many people use stale though so I've no idea if it'll be worth maintaing this extra option.
  2. Is this approach reasonable? I expect some change suggestions (especially to my rubbish naming) but it's worth disscussing the general approach of the code. The one problem I forsee is that this requires interrogating every issue for it's comments every time stale runs. This could potentially add a heavy load to Stale and it's understandable if we don't want to manage it. On the other hand, stale isn't something that needs to run "quickly" so maybe this is okay.

What do we think?

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

elliotblackburn commented 4 years ago

How ironic ^_^

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

elliotblackburn commented 4 years ago

I believe this is still relevant, and would love some feedback if possible. It looks like the project is being left in an as-is state though. Given that I'll let this tick through once more on the off chance this comes back into a maintained state, assuming it doesn't I'll let stale do it's thing.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?