probot / stale

A GitHub App built with Probot that closes abandoned Issues and Pull Requests after a period of inactivity.
https://probot.github.io/apps/stale/
ISC License
1.25k stars 212 forks source link

Future deprecation of stale app #248

Open gr2m opened 5 years ago

gr2m commented 5 years ago

We do plan to deprecate the stale app in favor of https://github.com/marketplace/actions/close-stale-issues some point in the future.

However, at this point there are two blockers:

  1. Actions do not have have access to org/account-wide configuration (.github repository)
  2. Actions do not provide a single setup for a whole org/account (or selected repositories)

We don't know if these two blockers will be addressed by new GitHub Action features in future, but for now we decided to keep the stale app running

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.53. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

jidanni commented 5 years ago

We do plan to deprecate the stale app in favor of http://github.com/marketplace/actions/stale some point in the future.

404 Page not found.

gr2m commented 5 years ago

Looks like it was renamed: https://github.com/marketplace/actions/close-stale-issues

GitHub
Close Stale Issues - GitHub Marketplace
Action to close stale issues
ssbarnea commented 5 years ago

Considering that github actions is not free for paying github users regardless if their repos are free or not I would not hurry to deprecate the app or you will make impossible for lots of use the great stale bot.

gr2m commented 4 years ago

I was thinking about the stale app. I wonder if instead of deprecating it, we could run the bits that need to be scheduled once per hour using a GitHub action. Running a GitHub app from a GitHub action is pretty straight forward.

The benefit would be that the stale up could be setup and configured centrally, instead of per-repository

FranklinYu commented 4 years ago

Shall we migrate feature requests over to https://github.com/actions/stale?

GitHub
actions/stale
Marks issues and pull requests that have not had recent interaction - actions/stale
ssbarnea commented 4 years ago

Please do not deptecate. Workflows/Action enablement come with hidden lock-in costs. For example it will be impossible to merge PR that alter their files. The way to edit them is via github GUI and apply them without running any CI.

gr2m commented 4 years ago

Shall we migrate feature requests over to https://github.com/actions/stale?

Either works, we didn't decide on what we'll do yet

@ssbarnea For example it will be impossible to merge PR that alter their files. The way to edit them is via github GUI and apply them without running any CI.

Could explain in more detail, please? I'm not sure I understand

GitHub
actions/stale
Marks issues and pull requests that have not had recent interaction - actions/stale
webknjaz commented 4 years ago

@gr2m what Sorin means is that orgs that have legacy plans do not have any access to GitHub Actions, even in open source repos under those orgs. This means that those repos will be unable to migrate to that action and will lose the app, effectively not having access to the feature it provides. (Of course, it's easy to spawn own instance of the app or write own implementation but it's not the same)

Context: https://twitter.com/webKnjaZ/status/1194964915506831362

Twitter
Sviatoslove.py🐍 πŸ‘¨β€πŸ’»πŸ‘:πŸ‡¨πŸ‡ΏπŸ‡ͺπŸ‡Ί @Ansible @RedHat on Twitter
β€œBummer! Apparently, #GitHubActions aren't available to orgs that *pay* @GitHub but are on "legacy" plan. They don't get *any* access to those. Not even for Open Source repos as advertised by marketing. It's unfair. Workaround: create a FOSS-only org and move public repos there.”
MaicolBen commented 4 years ago

I see some abandonment from https://github.com/marketplace/actions/close-stale-issues in their Github, so I wouldn't deprecate it soon yet.

GitHub
Close Stale Issues - GitHub Marketplace
Action to close stale issues
stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

tenshiAMD commented 2 years ago

However, at this point there are two blockers:

  1. Actions do not have have access to org/account-wide configuration (.github repository)
  2. Actions do not provide a single setup for a whole org/account (or selected repositories)

@gr2m I think these can be addressed now by chaining workflows and making one main workflow configuration to be reusable across the whole organization.

https://docs.github.com/en/actions/using-workflows/reusing-workflows

NOTE: However some still prefer using probot-based apps since actions are limited in private repos (only 2000 minutes for free plan - although can set workflow to run a few times).

Maybe we can still maintain and support this somehow forward. I am willing to help if that's possible. Also, I think other users are willing to help too.

GitHub Docs
Reusing workflows - GitHub Docs
Learn how to avoid duplication when creating a workflow by reusing existing workflows.
gr2m commented 2 years ago

reusable workflows is not the same as a single setup. You still need a workflow file in every repository that you you want to run the reusable workflow in