search

probot / template

Template for new Probot apps
https://probot.github.io/docs/development/#generating-a-new-app
ISC License
51 stars 166 forks source link

Bake nodemon into the sample app? #41

Closed zeke closed 6 years ago

zeke commented 6 years ago

The current development docs recommend setting up nodemon for a more convenient dev experience. I generally agree with this recommendation, and think it might make sense to just bake nodemon right into this template, with an npm run dev script to boot.

@bkeepers mentioned some past issues with nodemon and express not cooperating, but we've been using the two on electronjs.org for a while and haven't had any trouble.

What do folks think of this idea? Worth it for the smoother onboarding, or too opinionated and/or bloated?

bkeepers commented 6 years ago

If it works well, I'm 👍 for trying it. If people don't want it or don't like it, they can remove it.

And to get a sense of the impact, it adds 200 packages (+45%) and 6MB (+7%):

$ npx create-probot-app
…

$ du -sh node_modules 
 90M    node_modules

$ npm install -D nodemon
…

+ nodemon@1.14.11
added 200 packages in 8.113s

$ du -sh node_modules   
 96M    node_modules
JasonEtco commented 6 years ago

I install nodemon on every new app I work on, so I'm +1 for this. I think we would also want to change the docs a bit to reflect such a change.

itaditya commented 6 years ago

:+1: for me too.