search

probot / template

Template for new Probot apps
https://probot.github.io/docs/development/#generating-a-new-app
ISC License
51 stars 166 forks source link

use standard fix #52

Closed zeke closed 6 years ago

zeke commented 6 years ago

This PR updates the test script to use standard --fix, which can clean up a lot of minor linting issues for you automatically.

request-info[bot] commented 6 years ago

The maintainers of this repository would appreciate it if you could provide more information.

zeke commented 6 years ago

will it get corrected during the test run and not be reported as an error?

If the PR author didn't lint first, Yes. But it will come out in the wash. The next time someone lints locally, they'll commit the fixes.

bkeepers commented 6 years ago

Ehh, but then you'll have PRs that are modifying unrelated parts of the code base just to get the tests to pass.

zeke commented 6 years ago

Fair enough. Maybe we should add a lint script that's standard --fix for discoverability?

bkeepers commented 6 years ago

👍 want to give feedback on https://github.com/probot/template/pull/50 for that?