Currently description is causing issues when it contains double quotes as they break the package.json file by making the resulting JSON file invalid. As discussed in https://github.com/probot/probot/issues/727 we can escape all variables and if something was encoded improperly it's up to the end user to fix the template issues. While it's a minor inconvenience, this guarantees that the create-probot-app template always works at the cost of potentially HTML escaping something we didn't want to.
What
Escape all handlebars template variables
Why
Currently
description
is causing issues when it contains double quotes as they break the package.json file by making the resulting JSON file invalid. As discussed in https://github.com/probot/probot/issues/727 we can escape all variables and if something was encoded improperly it's up to the end user to fix the template issues. While it's a minor inconvenience, this guarantees that thecreate-probot-app
template always works at the cost of potentially HTML escaping something we didn't want to.cc: @hiimbex
View rendered CODE_OF_CONDUCT.md View rendered README.md