Added ingestion support for Coinbase and Bittrex

probstj / ccGains

Python package for calculating cryptocurrency trading profits and creating capital gains reports

GNU Lesser General Public License v3.0

49 stars 13 forks source link

Added ingestion support for Coinbase and Bittrex #8

Closed anson-vandoren closed 5 years ago

anson-vandoren commented 5 years ago

CSV file ingestion for transfers and trades for both exchanges. Tested satisfactorily on actual data

probstj commented 5 years ago

Again, it would be nice if you could add simple docstrings to the two new methods. :)

anson-vandoren commented 5 years ago

Done. I don't see why GitHub is complaining anymore, as I already pulled in the recent Electrum wallet changes. If you need me to fix something else, please do let me know.

probstj commented 5 years ago

Great, thanks!

It's probably complaining because the formatting was changed in between. OK, I'll see how resolving works here, never done it here... :)

probstj commented 5 years ago

OK, it was nothing: It essentially complained that you replaced an empty line with your additions... lol