Closed tbouffard closed 1 year ago
:recycle: PR Preview 36595e0fb1098cfa69e99a08ca09403168d33982 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Add several unit tests and simplify the implementation.
closes #18
Notes
Current limitation
The current implementation doesn't filter out erroneous edge identifiers that are resolved from incorrectly defined incoming and outgoing identifiers.
bpmn-visualization
doesn't filter them out itself when it should, so I decided not to do it here but to create an issue in thebpmn-visualization
repository instead: https://github.com/process-analytics/bpmn-visualization-js/issues/2852Note that the old implementation didn't filter out these erroneous edge identifiers either, so there's no reason to keep it instead of switching to the new implementation.
All code is now fully covered by tests 🎉