process-analytics / bpmn-visualization-examples

Examples of use of the `bpmn-visualization` library.
https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/master/examples/index.html
Apache License 2.0
55 stars 19 forks source link

[BUG] Fix the impact of the BpmnSemantic in examples when integrating bpmn-visualization 0.41.0 #549

Closed tbouffard closed 11 months ago

tbouffard commented 1 year ago

https://github.com/process-analytics/bpmn-visualization-js/pull/2854 introduces several new properties. The javascript-tooltip-and-popover example displaying BpmnSemantic information should be reviewed to see if properties display correctly (if applicable) The order of properties may be reworked.

tbouffard commented 11 months ago

❌ Check with https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/v0.41.0/examples/custom-behavior/javascript-tooltip-and-popover/index.html

I suggest we filter the properties with N/A values except the name property as we did before. We could display the parentId, but here it will always be undefined. This seems unnecessary, so I propose not to display it.

Before After
before after
csouchet commented 11 months ago

I don't see why that's a problem, since that's what we wanted to display in the first place, but I don't mind not displaying them anymore :slightly_smiling_face:

tbouffard commented 11 months ago

I don't see why that's a problem, since that's what we wanted to display in the first place, but I don't mind not displaying them anymore 🙂

Some popovers are too large so some information is not visible whereas properties without data are displayed. This is what I tried to explain in https://github.com/process-analytics/bpmn-visualization-examples/issues/549#issuecomment-1745327013

AFAIK, we introduced a generic mechanism to be able to display all properties, but without filtering undefined data. What I suggest is to improve this by displaying all defined values and explicitly choose which properties to display with a N/A value (only "name") when it is undefined.