[INFRA] Review and update GitHub Labels

[tbouffard]

We previously worked on that topic through #9

Status The default GitHub labels (enhancement, bug, ...) have been renamed and now start upper case. This causes the following issues

• issue templates label setting does not work any more as they reference lowercase labels (they could be updated). So this requires manual settings afterwards. Also remember that only collaborators can set labels on issues and PR, so issue created by outsiders will require label changes
• this is uncommon in GitHub repositories to use such customized labels. This is something which is implicitly standardized: developers are used to these label names, they know their meaning at first glance
• not having strict label name policy will mess tooling based on issue/PR labels (for instance release-drafter)

Proposal

• all labels (usual and custom) should have a description to clarify their meaning and when they can be used (PR only for instance like Rebase Needed)
• usual GitHub labels: keep the original lowercase names, avoid usage icons.
• custom labels: use icons if it helps

Questions

• do we need a security label for dependencies upgrade due to CVE
• labels related to questions: question is a usual label for issue categorization. We introduced question asked and question answered for PR follow-up
  • do we keep them?
  • if so, how do we clearly distinguish them from the usual label

[aibcmars]

to respond to your questions:

1. security label can be cool to have - for priority
2. I personally do not need these: 'question asked/answered'. I am more sticked to the native 'Add comment' 'Resolve conversation' github flow

[tbouffard]

to respond to your questions:

1. security label can be cool to have - for priority

2. I personally do not need these: 'question asked/answered'. I am more sticked to the native 'Add comment' 'Resolve conversation' github flow

same for me

[tbouffard]

Conclusion: @csouchet and @aibcmars are ok with the proposal + 'question asked/answered' removal

[tbouffard]

Changes on 2020-05-12

all labels now

• start with lower case except when using acronym (BPMN, WIP)
• have a description

pseudo-standard GitHub labels

• icons removal
  • help wanted
  • invalid
• rename
  • won't fix into wontfix

changes

• rebase needed:
  • icon from :scream: to :collision: (collision, as mergeability produces collision on master)
  • color from #d93f0b to #ffa500

additions

• cla not signed: prepare #187

removals

• Question answered
• Feedbacks integrated: label can only be set by repo collaborator so it couldn't be used by external contributors which limits a lot it uses, alternatives exist (add comment to ping collaborator/assignee, ...)

Review needed @aibcmars and @csouchet can you have a look at the changes I did If ok, please just put a :+1: reaction and/or close the issue

:information_source: next time we want to change or review GitHub labels, we could setup an GH workflow to manage labels in a declarative way, using for instance

• https://github.com/micnncim/action-label-syncer
• https://github.com/lannonbr/issue-label-manager-action

[tbouffard]

Closed as all core contributors agreed