refactor: simplify some code using the mxGraph API

process-analytics / bpmn-visualization-js

A TypeScript library for visualizing process execution data on BPMN diagrams

Apache License 2.0

224 stars 30 forks source link

Closed tbouffard closed 2 months ago

tbouffard commented 2 months ago

CoordinatesTranslator: remove extra null check

buildParameter: shape properties are assumed to be set by the CellRender, according to the cell style. So only use properties for the shape style.

NOTE: we have a large number of tests, very varied, so they would have detected regressions in code changes if there were any.

github-actions[bot] commented 2 months ago

🎊 PR Preview 1fba28f462ff967b39903570ef22746c9e94d809 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3153.surge.sh

🕐 Build time: 0.011s

github-actions[bot] commented 2 months ago

🎊 PR Preview 1fba28f462ff967b39903570ef22746c9e94d809 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3153.surge.sh

🕐 Build time: 0.01s

sonarcloud[bot] commented 2 months ago