process-analytics / bpmn-visualization-js

A TypeScript library for visualizing process execution data on BPMN diagrams

https://process-analytics.github.io/bpmn-visualization-js/

Apache License 2.0

224 stars 31 forks source link

[FEAT] Fix the size of the marker icon #465

Open csouchet opened 4 years ago

csouchet commented 4 years ago

Is your feature request related to a problem? Please describe. 0.1.7 rendering, the size of the marker depends on the size of the activity

Describe the solution you'd like We want to be able to define the size of the marker as we do for marker margins. Need to introduce a new parameter in PaintParameter, to fix the size of the icon, for the marker

tbouffard commented 4 years ago

This may be managed with a solution shared with #211

tbouffard commented 4 years ago

539 was a 1st step: the marker size does not depend on the size of the activity.

The size is the one defined in the IconPainter implementation for each marker, which is ok from a user point of view for now. The ability to choose the actual size and to configure it is still not implemented.

See https://github.com/process-analytics/bpmn-visualization-js/pull/539#pullrequestreview-471469769 for more details

tbouffard commented 8 months ago

Proposed prototype to implement this issue: https://github.com/process-analytics/bpmn-visualization-js/pull/2724#issuecomment-1997932820

tbouffard commented 2 months ago

Decision

Decided on 2024-04-04 (see #2724)

enforce marker width + review width value: value 12, see https://github.com/process-analytics/bpmn-visualization-js/pull/2724#issuecomment-2004574370