search

process-analytics / bpmn-visualization-js

A TypeScript library for visualizing process execution data on BPMN diagrams
https://process-analytics.github.io/bpmn-visualization-js/
Apache License 2.0
216 stars 29 forks source link

[FEAT] Review activity markers margin and spacing #992

Open tbouffard opened 3 years ago

tbouffard commented 3 years ago

The spacing is currently too large and we should reduce it.

markers 02 different tasks sizes-snap Non regression visual tests for markers with bpmn-visualization@0.9.0

The margin should be decreased as well to let more space for label. Notice that the following screenshot probably shows that the 'expand' marker is too large as well (#465). Be careful with the "Transaction Sub-Process" that may draw the second rectangle inside the shape (the Call Activity large stroke is drawn outside the shape).

B.1.0 call activity B.1.0 call activity with bpmn-visualization@0.9.0

Implementation proposal

Changing spacing and margin only requires to change constant values. Please try new values as a proposal to let discussions happen. Screenshots are welcome.

Decision

Decided on 2024-04-04 (see #2724)

tbouffard commented 6 months ago

Proposed prototype for the spacing : https://github.com/process-analytics/bpmn-visualization-js/pull/2724#issuecomment-1997932820