Compliance-rules/ripple circles: they shouldn't disappear after navigation

assynour commented 2 years ago

The ripple circles disappear after navigation/zooming or after adding a css class. Similar behavior as in #2

assynour commented 2 years ago

To reproduce:

click on show compliance rules
ripple circles appear
move the diagram

ripples1

assynour commented 2 years ago

To create the ripple circles, I add and animate svg circles to the svg group element of the bpmn activity. The corresponding code is in compliance-rules.js, function addRipleCircles().

tbouffard commented 2 years ago

https://github.com/process-analytics/bpmn-visualization-js/pull/2199 may fix this issue and #2

https://user-images.githubusercontent.com/27200110/186952139-685be0a7-bb8c-481b-9fb0-2037661657e7.mp4

How to reproduce

build bpmn-visualization PR 2199 bundles: npm run build-bundles
link the local bpmn-visualization npm package: npm link ../bpmn-visualization-js (here, the command assumes that the 2 folders are stored in the same root directory)
clear the vite cache (in node_modules/.vite/deps)
restart the dev server

process-analytics / icpm-demo-2022

Compliance-rules/ripple circles: they shouldn't disappear after navigation #4