process-analytics / icpm-demo-2022

The demo presented at ICPM 2022
https://process-analytics.github.io/icpm-demo-2022/
Apache License 2.0
3 stars 1 forks source link

[REFACTOR] Reorganize the CSS rules #72

Open tbouffard opened 2 years ago

tbouffard commented 2 years ago

This particularly applies to Happy Path rules but review all css rules.

happy-path rules There is no need to declare class by types. The CSS classname should always be the same and the CSS rule should required both the BPMN CSS classes and the specific classes. For intance bpmn-type-activity.happy-path

The from/to stroke are not needed in the animation if the grow keyframes (same values for from and to), if the value was correctly set in the CSS rule referencing this keyframes declaration

https://github.com/process-analytics/icpm-demo-2022/blob/227ddbb235ff089c94a5a04ce805ece7b7a10eb5/src/assets/styles.css#L175-L189