processing / p5.accessibility

p5.accessibility.js makes the p5 canvas more accessible to people who are blind and visually impaired. It can be used with any p5.js sketch and it is used in the p5.js web editor.
GNU Lesser General Public License v2.1
74 stars 27 forks source link

Added tests #104

Closed spiray closed 6 years ago

spiray commented 6 years ago

I added tests for the Interceptor Helper Functions. https://github.com/processing/p5.accessibility/blob/f1a11c05ef366f8d3dd0662665f34bcdd974d331/src/interceptorHelperFunctions.js#L20-L48 Should this be

if(!Array.prototype.equals){
  // Add method
}

This is causing the tests to fail as it isn't modifying the Array.prototype because the logic indicates that it should only set the method if the method already exists.

MathuraMG commented 6 years ago

Look great!