search

processing / p5.accessibility

p5.accessibility.js makes the p5 canvas more accessible to people who are blind and visually impaired. It can be used with any p5.js sketch and it is used in the p5.js web editor.
GNU Lesser General Public License v2.1
74 stars 27 forks source link

rename some args #135

Open mithru opened 6 years ago

mithru commented 6 years ago

Nature of issue

I realized things like the below line from fillEntity.js use the name shapeObject which perhaps makes sense in shapeEntity.js but the meaning doesn't carry through for newer methods. Maybe we can rename it to methodObject ? I sure helps me understand the code a lot better.

function FillEntity(Interceptor, shapeObject, fillArgs, canvasX, canvasY)

For reference, if I console.log(shapeObject) I get this

{name: "fill", params: Array(4), class: "p5", module: "Color", submodule: "Setting"}

Thoughts?

mithru commented 6 years ago

I can do this, if we decide to make this change. Regardless, I'm using methodObject on newer entities that I implement.