search

processing / p5.accessibility

p5.accessibility.js makes the p5 canvas more accessible to people who are blind and visually impaired. It can be used with any p5.js sketch and it is used in the p5.js web editor.
GNU Lesser General Public License v2.1
74 stars 27 forks source link

Converted the BaseEntity class to ES2015 Class syntax #68

Closed spiray closed 6 years ago

spiray commented 6 years ago

@MathuraMG @lm-n I decided to get rid of my previous work and start fresh. I wanted to start slow to make sure that we are fully on the same page. Here is 1 class (BaseEntity) converted to ES2015 syntax. Let me know what you think. We also need to make a decision on what we are replacing the parameter arguments with, for now i just changed it to argumentss. It is causing issues. Other than that keyword the examples are working fine with the updated class syntax.

MathuraMG commented 6 years ago

how about p5arguments? Also, to clarify, is this (src/entities/_baseEntity.js) the only file with ES6 right now?

MathuraMG commented 6 years ago

The rules in the eslint look like a good start! Can we maybe add no-var too?

spiray commented 6 years ago

I started with that file. I will edit the script to execute on all js files in /src. I will add no-var as well.

spiray commented 6 years ago

I am getting an error when i test it. I can't pinpoint what is causing it though. image

spiray commented 6 years ago

@lm-n Yes, i will really take it slow this next time to make sure we are on the same page.

lm-n commented 6 years ago

@spiray the other files look good so we're happy to merge if you make the fix on src/textInterceptor/interceptorFunctions.js and bring the entities back to what they were.

MathuraMG commented 6 years ago

@spiray - totally agree with @lm-n, the work was good, it just needs the fixes :+1 Also, we noticed that you are making changes on your master, if you instead make it on branches, it'll be easier to have multiple copies of the code!