search

processing / p5.accessibility

p5.accessibility.js makes the p5 canvas more accessible to people who are blind and visually impaired. It can be used with any p5.js sketch and it is used in the p5.js web editor.
GNU Lesser General Public License v2.1
74 stars 27 forks source link

Linting #70

Closed spiray closed 6 years ago

spiray commented 6 years ago

I added the .eslintrc.js file. Once this is approved and merged i will start linting all .js files. Thanks!

MathuraMG commented 6 years ago

Hey @spiray - not sure if you saw our comments in the previous PR, let us know if you would like to reopen that, or go ahead with this!

spiray commented 6 years ago

Hi @MathuraMG I did see them. I had a religious holiday so i had take some time off. I will get organized with how i work on this but i think it will be best to move forward with this one. The other changes didn't take much time.

MathuraMG commented 6 years ago

@spiray - that sounds good! We will review this then. Hope you had a good holiday :)

MathuraMG commented 6 years ago

@spiray - the eslint file looks to be a good starter file. Can we also add quotes for this version? (it helps making the code look clean :))

@lm-n - What do you think?

spiray commented 6 years ago

I didn't notice any double quotes so i didn't think it was needed but i can add it in. Would you want to do backticks? that will be even more uniform especially if we are doing template strings.

MathuraMG commented 6 years ago

@spiray - that sounds like a good idea

lm-n commented 6 years ago

@spiray I'm closing this so that we can continue on #72