search

processing / p5.js-editor

Deprecated desktop editor for p5.js
https://p5js.org
MIT License
338 stars 91 forks source link

Electron port #246

Open davejm opened 8 years ago

davejm commented 8 years ago

From issue #77

Hi,

I set myself the task of making an app in Electron over the Summer and this seemed like a good project to work on with a head start in the logic so I've been working on a port to Electron.

I thought it would be pretty painless but turned out to be quite complicated given the completely different architecture of Electron and the process model.

Anyway I've taken a stab and I think the core functionality is pretty much there. The branch is here: https://github.com/davejm/p5.js-editor/tree/electron-port and there are some notes on the conversion here: https://github.com/davejm/p5.js-editor/blob/electron-port/nw-to-electron-conversion-notes.md.

I based it off an electron vue boilerplate which is linked in the notes. Currently, I'm going to have to take a break from it but it'd be great to finish!

I'm happy to answer any questions and hopefully it can be of some use to the p5js editor project if you want to head in the Electron direction. Let me know if this interests anyone.

This is definitely a work in progress!

Thanks @antiboredom @lmccart

bensk commented 8 years ago

Do you have a compiled version we could test? I'm having trouble building my own. Thanks!

davejm commented 8 years ago

Hi @bensk I'll try and get a snapshot build up this evening but may not have time! It'll likely be quite unstable but we'll see.

bensk commented 8 years ago

@davejm thanks so much!

davejm commented 8 years ago

@bensk out of interest, is there a particular reason you want to test it? (could try to get something in particular working)

bensk commented 8 years ago

@davejm I teach p5 during the year, and have been frustrated by the desktop editor. I like having a dedicated editor for my students, and love Atom, so Electron seemed like the next logical step.

davejm commented 8 years ago

Ok @bensk. I made a release with compiled binaries. Note there will be bugs. My goal is to at least achieve parity with the nwjs branch. Really there won't be that much difference between the electron and nwjs apps to the user but it's an improvement for development and maintenance I think. Anyway the release is here: https://github.com/davejm/p5.js-editor/releases/tag/v0.6.0-ELECTRON.1 Please tell me how it goes. Also just close the dev tools that open. That's for testing

bensk commented 8 years ago

Thanks!

On Mon, Jul 18, 2016 at 5:32 PM, David Moodie notifications@github.com wrote:

Ok @bensk https://github.com/bensk. I made a release with compiled binaries. Note there will be bugs. My goal is to at least achieve parity with the nwjs branch. Really there won't be that much difference between the electron and nwjs apps to the user but it's an improvement for development and maintenance I think. Anyway the release is here: https://github.com/davejm/p5.js-editor/releases/tag/v0.6.0-ELECTRON.1 Please tell me how it goes

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-editor/pull/246#issuecomment-233465651, or mute the thread https://github.com/notifications/unsubscribe-auth/AHGwhGtdjhUkI5Eul4A-4x2RPBjoQDHLks5qW_DxgaJpZM4I4jJw .