search

processing / p5.js-video

177 stars 38 forks source link

hello.p5js.org text for non-WebGL browsers could be more helpful #44

Closed CraigStuntz closed 10 years ago

CraigStuntz commented 10 years ago

If you visit hello and the site doesn't think your browser supports WebGL, the page is fairly unhelpful. There are no links to or description of, for example, what p5 actually is.

scottgarner commented 10 years ago

Very good point. I'll link to p5js.org for users that can't view the demo. — Sent from Mailbox

On Wed, Aug 6, 2014 at 2:19 PM, Craig Stuntz notifications@github.com wrote:

If you visit hello and the site doesn't think your browser supports WebGL, the page is fairly unhelpful. There are no links to or description of, for example, what p5 actually is.

Reply to this email directly or view it on GitHub: https://github.com/scottgarner/p5.js-video/issues/44

lmccart commented 10 years ago

maybe we just show the message and redirect after a few seconds to p5js.org?

let's also make sure it's clear in the error message that webgl isn't required for p5.js itself. maybe something like:

"Sorry! Your browser doesn't support all of the features required for this intro video demo, but you can continue to p5js.org to learn more about the library."

scottgarner commented 10 years ago

There are technically two error messages, though a bug was causing them both to be displayed. One for WebGL:

Your browser doesn't appear to support WebGL or it isn't enabled. Visit get.webgl.org to learn more or try the latest version of Chrome.

And one for general feature detection (webaudio, csstransforms, etc.):

Your browser doesn't support all of the features required for this demo. Please consider using the latest version of Chrome.

The only place you'll likely ever see the second one is in IE 11, which bafflingly supports WebGL but not the Web Audio API. It isn't strictly necessary to have two different errors, but it has become fairly common practice to link to get.webgl.org for WebGL errors.

In both cases you'll now get this line:

Don't worry, you can still learn all about p5.js at p5js.org.

Happy to change the wording anywhere to make it more clear.