Undo/Redo does not work on iPad and iPhone

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.41k stars 1.35k forks source link

Undo/Redo does not work on iPad and iPhone #1027

Open garrytaulu opened 5 years ago

garrytaulu commented 5 years ago

Nature of issue?

Found a bug

Details about the bug:

Unable to undo typing in the editor. CMD + Z does not work and neither do the software undo and redo buttons.

Web browser and version: Safari
Operating System: iOS 12.2
Steps to reproduce this bug: Use editor on iPad with either software keyboard or hardware keyboard

garrytaulu commented 5 years ago

Did some quick research on this, it looks like CodeMirror 5.x has broken undo/redo on iOS as it works fine in CodeMirror 3. Probably not much you can do but I’ve raised the issue with CodeMirror as well https://github.com/codemirror/CodeMirror/issues/5850

catarak commented 5 years ago

thanks for reporting! i wonder if there's a work around...

garrytaulu commented 4 years ago

Looks like hardware keyboards work now but the software 'undo' and 'redo' buttons still do not work.

catarak commented 4 years ago

Okay, thanks for the update. Hopefully CodeMirror 6 will fix this issue (no idea when that will be released though!).

catarak commented 3 years ago

I'm having a hard time figuring out how to connect CodeMirror to the undo/redo buttons on iPad software keyboards. For mobile development, I think it makes sense to have Undo and Redo buttons that appear, but that still would't show up here.